Skip to content

Conversation

@josephwkania
Copy link

Changes include

  • Reformat with Black
  • Lint to be compatible with Flake8
  • Allow CI Flake8 to fail when Flake8 conflicts with Black
  • Fixes in requirements.txt
  • Tests against Multiple Python versions

There are no functionality changes in this PR.

@damonge
Copy link
Collaborator

damonge commented Dec 13, 2024

Thanks @josephwkania . Looks good to me, although I'm not sure why the linting test is not running...

@josephwkania
Copy link
Author

My changes to do multiple Python versions made the tests not line up with the required check. I reverted to doing one test with
Python 3.11.

@josephwkania
Copy link
Author

Hi @damonge, any thoughts on this/anything else you want me to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants