feat: add type 2 and 3 scans to generate scan #917
Conversation
|
@skhrg Can you record here (or on Slack) some specific times when you ran type 2 and type 3 with this code? I want to see the turn-arounds and the phasing behavior. |
There was a problem hiding this comment.
I took a quick look at this. Other than the small docstring change it looks good to me, though I didn't really focus on the math related to generating the actual scans, as I don't know the details there to really say anything critical.
The one thing you might add is some general description of what type 1/2/3 scans are in the description on the agent page.
I won't give explicit approval here, @mhasself should have final sign-off.
socs/agents/acu/drivers.py
Outdated
| az_drift=None): | ||
| """Python generator to produce times, azimuth and elevation positions, | ||
| azimuth and elevation velocities, azimuth and elevation flags for | ||
| arbitrarily long type 3 scan. |
There was a problem hiding this comment.
| arbitrarily long type 3 scan. | |
| arbitrarily long type 2 scan. |
You can see that the el nods act up a bit at turnarounds. |
| @ocs_agent.param('el_endpoint1', type=float, default=None) | ||
| @ocs_agent.param('el_endpoint2', type=float, default=None) | ||
| @ocs_agent.param('el_speed', type=float, default=0.) | ||
| @ocs_agent.param('el_freq', type=float, default=None) |
socs/agents/acu/agent.py
Outdated
| Type 2 includes a variation in az speed that scales as sin(az). | ||
| Type 3 is a Type 2 with an sinusoidal el nod. | ||
| az_vel_ref (float or None): azimuth to center the velocity profile at. | ||
| If None then the average of the endpoints is used. |
There was a problem hiding this comment.
Please respect the docstring formatting of this function. Indentation.
| batch_size=batch_size, | ||
| az_start=az_start, | ||
| az_first_pos=az_first_pos, | ||
| az_drift=az_drift) |
There was a problem hiding this comment.
You need to pass through az_vel_ref.
for more information, see https://pre-commit.ci
Adds type 2 and 3 scans to the ACU agent
Description
generate_scanto allow for these scansset_scan_parametersto also setel_freqfor type 3Motivation and Context
Enables the use of these new scan types for the LAT.
This is needed for ISO.
How Has This Been Tested?
Testing by running the ACU agent out of my homedir on site computing.
Scans ran successfully.
Types of changes
Checklist: