Skip to content

Check if sensor list is changing and adjust. #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Check if sensor list is changing and adjust. #928

wants to merge 3 commits into from

Conversation

msilvafe
Copy link
Contributor

Fixes #927

Description

Checks if sensor list has changed (due to deactivating or activating slots) and if so re-grabs the list of desired sensors to query.

Motivation and Context

See #927

How Has This Been Tested?

Hasn't been tested, needs testing on site.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianJKoopman BrianJKoopman Awaiting requested review from BrianJKoopman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smurf crate agent: bug on missing sensors
2 participants
@msilvafe @BrianJKoopman