Skip to content

Conversation

BrianJKoopman
Copy link
Member

This should remove the potentially unclear message pointed out in #164. If we hit the timeout we just print a message about it, then move to the error raised if 'running' wasn't the found state:

if op_code != 3: # RUNNING
error = f"Operation {op} in Agent {instance} is not 'running'.\n" + \
f"Current OpCode: {op_code}\n" + str(response)
raise RuntimeError(error)

@mhasself, does this clear things up?

Resolves #164.

@BrianJKoopman BrianJKoopman requested a review from mhasself June 16, 2025 20:15
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrianJKoopman BrianJKoopman merged commit 5e86bdb into main Jun 18, 2025
4 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/issue-164 branch June 18, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially misleading error message in _check_started
2 participants