Skip to content

Remove potentially unclear error message #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Remove potentially unclear error message #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/sorunlib/_internal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,14 @@ def check_started(client, response, timeout=60):
# Wait at most ~timeout seconds while checking the status
for i in range(timeout):
response = _operation.status()
_check_error(client, response)
op_code = response.session.get('op_code')
if op_code == 3:
if op_code == 3: # RUNNING
# Tricky to change state during testing w/little reward
return # pragma: no cover
time.sleep(1)

error = f"Check timed out. Operation {op} in Agent {instance} stuck in " + \
"'starting' state.\n" + str(response)
raise RuntimeError(error)
print("The operation is in an unexpected state after {timeout} seconds.")

if op_code != 3: # RUNNING
error = f"Operation {op} in Agent {instance} is not 'running'.\n" + \
Expand Down