Skip to content

Fix IQR division for glitches #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix IQR division for glitches #1349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sotodlib/tod_ops/flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,11 +396,13 @@ def get_glitch_flags(aman,
subscan_indices = np.array([[0, fvec.shape[-1]]])

msk = np.zeros_like(fvec, dtype='bool')
iqr_ranges = np.zeros_like(fvec)
if fvec.ndim == 1:
for ss in subscan_indices:
iqr_range = 0.741 * stats.iqr(fvec[ss[0]:ss[1]:ds])
# get flags
msk[ss[0]:ss[1]] = fvec[ss[0]:ss[1]] > iqr_range * n_sig
iqr_ranges[ss[0]:ss[1]] = iqr_range
msk[:edge_guard] = False
msk[-edge_guard:] = False
flag = Ranges.from_bitmask(msk)
Expand All @@ -409,6 +411,7 @@ def get_glitch_flags(aman,
iqr_range = 0.741 * stats.iqr(fvec[:,ss[0]:ss[1]:ds], axis=1)
# get flags
msk[:,ss[0]:ss[1]] = fvec[:,ss[0]:ss[1]] > iqr_range[:, None] * n_sig
iqr_ranges[:,ss[0]:ss[1]] = iqr_range[:, None]
msk[:,:edge_guard] = False
msk[:,-edge_guard:] = False
flag = RangesMatrix([Ranges.from_bitmask(m) for m in msk])
Expand All @@ -427,7 +430,7 @@ def get_glitch_flags(aman,
# do not compress into csr_array
glitches = core.AxisManager(aman.samps)
data = np.zeros_like(fvec)
data[msk] = fvec[msk] / iqr_range
data[msk] = fvec[msk] / iqr_ranges[msk]
glitches.wrap("glitch_flags", flag, [(0, "samps")])
glitches.wrap("glitch_detection", data, [(0, "samps")])
else:
Expand All @@ -436,7 +439,7 @@ def get_glitch_flags(aman,
)
indices = np.concatenate([np.where(msk[i])[0] for i in range(aman.dets.count)])
data = np.concatenate(
[fvec[i][msk[i]] / iqr_range[i] for i in range(aman.dets.count)]
[fvec[i][msk[i]] / iqr_ranges[i][msk[i]] for i in range(aman.dets.count)]
)
smat = csr_array(
(data, indices, indptr), shape=(aman.dets.count, aman.samps.count)
Expand Down