Skip to content

valid_data needs to be an axis manager #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

valid_data needs to be an axis manager #1383

wants to merge 1 commit into from

Conversation

mmccrackan
Copy link
Contributor

@mmccrackan mmccrackan commented Sep 18, 2025 •
edited
Loading

Problem showed up in #1346, but valid_data needs to be an AxisManager and not just a RangesMatrix so that it works with update_full_aman.

@mmccrackan mmccrackan requested a review from msilvafe September 18, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msilvafe msilvafe Awaiting requested review from msilvafe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmccrackan