Fix KeyError when sorting with _labels=on and excluded sort column #2600
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle both IndexError and KeyError when accessing sort column in _next_value_and_url. CustomRow objects (used with _labels=on) raise KeyError for missing columns, while sqlite3.Row raises IndexError. Adds tests for sorting with _labels=on when the sort column is excluded from SELECT via _col or _nocol parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle both IndexError and KeyError when accessing sort column in _next_value_and_url. CustomRow objects (used with _labels=on) raise KeyError for missing columns, while sqlite3.Row raises IndexError.
Adds tests for sorting with _labels=on when the sort column is excluded from SELECT via _col or _nocol parameters.
📚 Documentation preview 📚: https://datasette--2600.org.readthedocs.build/en/2600/