Release: v4.1.1 #241
Merged
Release: v4.1.1 #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复CreateInviteApi请求路径错误的问题
为BotRequests顶层挂起函数添加对应的Java桥接函数
There was a problem hiding this comment.
Pull Request Overview
This PR updates API request functions, fixes an incorrect API path in CreateInviteApi, and bumps project version numbers for the v4.1.1 release. Key changes include:
- Introducing new request functions in both the stdlib and core modules.
- Correcting the API path in CreateInviteApi from "invite/list" to "invite/create".
- Updating version constants and changelog entries.
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| simbot-component-kook-stdlib/src/jvmMain/kotlin/love/forte/simbot/kook/stdlib/BotRequests.jvm.kt | New API request functions using Bot as parameter. |
| simbot-component-kook-core/src/jvmMain/kotlin/love/forte/simbot/component/kook/util/BotRequests.jvm.kt | New API request functions using KookBot as parameter. |
| simbot-component-kook-core/src/commonMain/kotlin/love/forte/simbot/component/kook/util/BotRequests.kt | Updated file-level annotations for multifile classes. |
| simbot-component-kook-api/src/commonMain/kotlin/love/forte/simbot/kook/api/invite/CreateInviteApi.kt | Fixed API path typo for invite creation. |
| buildSrc/src/main/kotlin/P.kt | Updated version constants. |
| CHANGELOG.md & .changelog/v4.1.1.md | Added changelog details for v4.1.1 release. |
Files not reviewed (3)
- buildSrc/src/main/kotlin/simbot-kook-changelog-generator.gradle.kts: Language not supported
- simbot-component-kook-core/api/simbot-component-kook-core.api: Language not supported
- simbot-component-kook-stdlib/api/simbot-component-kook-stdlib.api: Language not supported
Comments suppressed due to low confidence (1)
simbot-component-kook-stdlib/src/jvmMain/kotlin/love/forte/simbot/kook/stdlib/BotRequests.jvm.kt:43
- [nitpick] The parameter type 'Bot' here contrasts with 'KookBot' used in the core module. If these types represent the same concept, consider unifying the naming to improve clarity across the codebase.
public fun KookApi<*>.requestByBlocking(bot: Bot): HttpResponse =
ForteScarlet
approved these changes
May 4, 2025
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
tag似乎加错提交了。不过问题应该不大 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #236