pass empty data in GET request

Author: boddumanohar

pkg/spdk/controllerserver.go

@@ -271,25 +271,24 @@ func prepareCreateVolumeReq(ctx context.Context, req *csi.CreateVolumeRequest, s
 	}
 
 	createVolReq := util.CreateLVolData{
-		LvolName:     req.GetName(),
-		Size:         fmt.Sprintf("%dM", sizeMiB),
-		LvsName:      params["pool_name"],
-		MaxRWIOPS:    params["qos_rw_iops"],
-		MaxRWmBytes:  params["qos_rw_mbytes"],
-		MaxRmBytes:   params["qos_r_mbytes"],
-		MaxWmBytes:   params["qos_w_mbytes"],
-		MaxSize:      params["max_size"],
-		PriorClass:   priorClass,
-		Compression:  compression,
-		Encryption:   encryption,
-		DistNdcs:     distrNdcs,
-		DistNpcs:     distrNpcs,
-		CryptoKey1:   cryptoKey1,
-		CryptoKey2:   cryptoKey2,
-		HostID:       hostID,
-		LvolID:       lvolID,
-		PvcName:      pvcName,
-		PvcNamespace: pvcNamespace,
+		LvolName:    req.GetName(),
+		Size:        fmt.Sprintf("%dM", sizeMiB),
+		LvsName:     params["pool_name"],
+		MaxRWIOPS:   params["qos_rw_iops"],
+		MaxRWmBytes: params["qos_rw_mbytes"],
+		MaxRmBytes:  params["qos_r_mbytes"],
+		MaxWmBytes:  params["qos_w_mbytes"],
+		MaxSize:     params["max_size"],
+		PriorClass:  priorClass,
+		Compression: compression,
+		Encryption:  encryption,
+		DistNdcs:    distrNdcs,
+		DistNpcs:    distrNpcs,
+		CryptoKey1:  cryptoKey1,
+		CryptoKey2:  cryptoKey2,
+		HostID:      hostID,
+		LvolID:      lvolID,
+		PvcName:     pvcName,
 	}
 	return &createVolReq, nil
 }

pkg/util/jsonrpc.go

@@ -421,6 +421,8 @@ func (client *RPCClient) CallSBCLI(method, path string, args interface{}) (inter
 		if err != nil {
 			return nil, fmt.Errorf("%s: %w", method, err)
 		}
+	} else {
+		data = nil
 	}
 
 	requestURL := fmt.Sprintf("%s/%s", client.ClusterIP, path)
@@ -448,9 +450,9 @@ func (client *RPCClient) CallSBCLI(method, path string, args interface{}) (inter
 	}
 
 	var response struct {
-		Result  interface{} `json:"result"`
-		Results interface{} `json:"results"`
-		Error   string      `json:"error"`
+		Result  any    `json:"result"`
+		Results any    `json:"results"`
+		Error   string `json:"error"`
 	}
 
 	err = json.NewDecoder(resp.Body).Decode(&response)

pkg/util/nvmf.go

@@ -89,7 +89,6 @@ type CreateLVolData struct {
 	HostID       string `json:"host_id"`
 	LvolID       string `json:"uid"`
 	PvcName      string `json:"pvc_name"`
-	PvcNamespace string `json:"namespace"`
 }
 
 // CreateVolume creates a logical volume and returns volume ID