Skip to content

remove namespace usage from CSI #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented May 31, 2025

this PR addresses 2 issues:

Issue 1:

The namespace parameter passed as a part of LVOL create is repurposed as a part of SFAM-2019. The new convention refers to NVMe namespace.

Issue 2:

Pass nil during GET request instead of {}

Testing

successful e2e run

Will run 5 of 8 specs
S
------------------------------
• [SLOW TEST] [85.546 seconds]
SPDKCSI-CLONE Test SPDK CSI Volume Clone Test SPDK CSI Clone
/home/runner/work/simplyBlockDeployGCP/simplyBlockDeployGCP/simplyblock-csi/e2e/clone.go:15
------------------------------
S•
------------------------------
• [SLOW TEST] [48.682 seconds]
SPDKCSI-NVMEOF Test SPDK CSI Dynamic Volume Provisioning Test the flow for Dynamic volume provisioning
/home/runner/work/simplyBlockDeployGCP/simplyBlockDeployGCP/simplyblock-csi/e2e/nvmeof.go:30
------------------------------
• [SLOW TEST] [81.847 seconds]
SPDKCSI-NVMEOF Test SPDK CSI Dynamic Volume Provisioning Test multiple PVCs
/home/runner/work/simplyBlockDeployGCP/simplyBlockDeployGCP/simplyblock-csi/e2e/nvmeof.go:52
------------------------------
S
------------------------------
• [SLOW TEST] [163.448 seconds]
SPDKCSI-SNAPSHOT Test SPDK CSI Snapshot Test SPDK CSI Snapshot
/home/runner/work/simplyBlockDeployGCP/simplyBlockDeployGCP/simplyblock-csi/e2e/snapshot.go:15
------------------------------

Ran 5 of 8 Specs in 380.248 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 3 Skipped
--- PASS: TestE2E (380.25s)

https://github.com/simplyblock-io/simplyBlockDeployGCP/actions/runs/15400210708/job/43330881473

@boddumanohar boddumanohar force-pushed the remove-namespace-usage branch from 4fd5487 to ee58b15 Compare June 2, 2025 15:55
@boddumanohar boddumanohar force-pushed the remove-namespace-usage branch from ee58b15 to df4e686 Compare June 2, 2025 16:15
@boddumanohar boddumanohar marked this pull request as ready for review June 2, 2025 16:41
@boddumanohar boddumanohar merged commit 6875555 into master Jun 2, 2025
4 checks passed
geoffrey1330 pushed a commit that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants