improvement(selectors): consolidate all integration selectors to use the combobox #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR consolidates all integration selectors into a unified architecture, removing over 6,000 lines of duplicated code while improving maintainability and caching. Key Changes
Architecture Improvements
Code QualityThe refactoring follows established architectural patterns from the codebase and properly uses memoization, TypeScript interfaces, and error handling throughout. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant UI as UI Component<br/>(file-selector-input)
participant Resolution as Resolver<br/>(resolution.ts)
participant Combobox as SelectorCombobox
participant Query as useSelector<br/>Query Hooks
participant Registry as Selector<br/>Registry
participant API as Backend APIs
participant Cache as TanStack<br/>Query Cache
UI->>Resolution: resolveSelectorForSubBlock(subBlock, context)
Resolution->>Resolution: Analyze subBlock type and provider
Resolution-->>UI: selectorKey and context object
UI->>Combobox: Render with selectorKey and context
Combobox->>Query: useSelectorOptions(selectorKey, context, search)
Query->>Registry: getSelectorDefinition(selectorKey)
Registry-->>Query: Definition with fetchList and getQueryKey
Query->>Cache: Check cache with queryKey
alt Cache Hit
Cache-->>Query: Cached options array
else Cache Miss
Query->>Registry: fetchList with context and search
Registry->>API: fetchJson to integration endpoint
API-->>Registry: Raw data from integration
Registry->>Registry: Transform to SelectorOption array
Registry-->>Query: Normalized options
Query->>Cache: Store with staleTime
end
Query-->>Combobox: options data and loading state
alt User has existing value
Combobox->>Query: useSelectorOptionDetail(selectorKey, detailId)
Query->>Cache: Check detail cache
alt Detail Cache Miss
Query->>Registry: fetchById with context and detailId
Registry->>API: POST to detail endpoint
API-->>Registry: Detailed option data
Registry-->>Query: SelectorOption object
Query->>Cache: Store detail
end
Query-->>Combobox: detailOption
end
Combobox->>Combobox: Merge list and detail with useSelectorOptionMap
Combobox-->>UI: Render options with EditableCombobox
alt User selects option
UI->>Combobox: User selects value
Combobox->>Combobox: handleSelection with value
Combobox->>UI: setStoreValue updates store
Combobox->>UI: onOptionChange callback fires
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate all integration selectors and remove display names cache to migrate to tanstack based access pattern.
Type of Change
Testing
Tested manually
Checklist