-
Notifications
You must be signed in to change notification settings - Fork 1.9k
docs:Add Chinese, French, Japanese version of README #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 9bb5591 in 2 minutes and 21 seconds
More details
- Looked at
723
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
10
drafted comments based on config settings.
1. README.md:117
- Draft comment:
Typo: Replace 'gd' with 'GDP' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. docs/README_FR.md:49
- Draft comment:
Consider updating the image path for the demo GIF to '../assets/demo.gif' for proper relative linking. - Reason this comment was not posted:
Marked as duplicate.
3. docs/README_JA.md:49
- Draft comment:
Consider updating the image path for the demo GIF to '../assets/demo.gif' for consistency in relative linking. - Reason this comment was not posted:
Marked as duplicate.
4. README.md:117
- Draft comment:
Typo: Replace 'gd' with 'GDP' in the chart plotting instruction. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. docs/README_CN.md:49
- Draft comment:
Incorrect relative asset path for demo gif. Use '../assets/demo.gif' instead of 'assets/demo.gif'. - Reason this comment was not posted:
Marked as duplicate.
6. docs/README_FR.md:49
- Draft comment:
Update demo gif path to '../assets/demo.gif' for consistency with the logo asset. - Reason this comment was not posted:
Marked as duplicate.
7. docs/README_JA.md:49
- Draft comment:
Demo gif asset path should be updated to '../assets/demo.gif' to correctly reference the asset. - Reason this comment was not posted:
Marked as duplicate.
8. docs/README_JA.md:121
- Draft comment:
Unresolved merge conflict detected. Please resolve the conflict in the chart image reference. - Reason this comment was not posted:
Marked as duplicate.
9. README.md:117
- Draft comment:
Typo detected: In the sentence "Plot the histogram of countries showing for each one the gd. Use different colors for each bar", 'gd' appears to be a typo. Please review and correct the intended word. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. docs/README_JA.md:121
- Draft comment:
It looks like merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> 2bfbc53) were accidentally left in the file. Please remove these markers and resolve the conflict. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_NjFaJfAaGUnXHSKO
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
) | ||
``` | ||
|
||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove merge conflict markers from the chart image line.
|
||
您的团队现在可以通过平台使用自然语言访问和查询这些数据。 | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider updating the image path for the demo GIF to ../assets/demo.gif
for proper relative linking.
 | |
 |
|
||
## Ressources | ||
|
||
> **Avis Beta** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typographical issue: Consider changing 'Avis Beta' to 'Avis bêta' for correct French orthography.
> **Avis Beta** | |
> **Avis bêta** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be able to ignore
## リソース | ||
|
||
> **ベータ版のお知らせ** | ||
> リリースv3は現在ベータ版です。以下のドキュメントと例は、進行中の機能と機能を反映しており、最終リリース前に変更される可能性があります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the beta notice section, the phrase "進行中の機能と機能を反映しており" contains a repetition of the word '機能'. Consider revising this wording to avoid redundancy (e.g., "進行中の機能を反映しており").
> リリースv3は現在ベータ版です。以下のドキュメントと例は、進行中の機能と機能を反映しており、最終リリース前に変更される可能性があります。 | |
> リリースv3は現在ベータ版です。以下のドキュメントと例は、進行中の機能を反映しており、最終リリース前に変更される可能性があります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comment as a non-native speaker
Added a navigation bar in the README for jumping to different language versions, and added README_CN, README_FR, README_JA, etc., in the docs directory.
Important
Add multilingual support to README with Chinese, French, and Japanese versions and a navigation bar for language selection.
README.md
for language selection: English, Chinese, French, Japanese.README_CN.md
for Chinese documentation.README_FR.md
for French documentation.README_JA.md
for Japanese documentation.This description was created by
for 9bb5591. It will automatically update as commits are pushed.