Do not cache metadata locally as it can cause too high memory usage during cache warming, just rely on the cache

Author: pmishev

Mapping/DocumentMetadataCollector.php

@@ -21,20 +21,6 @@ class DocumentMetadataCollector implements WarmableInterface
      */
     const OBJECTS_CACHE_KEY_PREFIX = 'sfes.object_properties_metadata.';
 
-    /**
-     * <document_class_FQN> => DocumentMetadata
-     *
-     * @var array
-     */
-    private $metadata = [];
-
-    /**
-     * <object_class_FQN> => [<properties_metadata>]
-     *
-     * @var array
-     */
-    private $objectsMetadata = [];
-
     /**
      * @var array
      *
@@ -129,16 +115,11 @@ public function getDocumentMetadata(string $documentClass): DocumentMetadata
     {
         $documentClass = $this->documentLocator->resolveClassName($documentClass);
 
-        if (isset($this->metadata[$documentClass])) {
-            return $this->metadata[$documentClass];
-        }
-
         $cacheKey = self::DOCUMENTS_CACHE_KEY_PREFIX.strtr($documentClass, '\\', '.');
-        $this->metadata[$documentClass] = $this->cache->get($cacheKey, function (ItemInterface $item) use ($documentClass) {
+
+        return $this->cache->get($cacheKey, function (ItemInterface $item) use ($documentClass) {
             return $this->fetchDocumentMetadata($documentClass);
         }, 0);
-
-        return $this->metadata[$documentClass];
     }
 
     /**
@@ -155,16 +136,11 @@ public function getObjectPropertiesMetadata(string $objectClass): array
     {
         $objectClass = $this->documentLocator->resolveClassName($objectClass);
 
-        if (isset($this->objectsMetadata[$objectClass])) {
-            return $this->objectsMetadata[$objectClass];
-        }
-
         $cacheKey = self::OBJECTS_CACHE_KEY_PREFIX.strtr($objectClass, '\\', '.');
-        $this->objectsMetadata[$objectClass] = $this->cache->get($cacheKey, function (ItemInterface $item) use ($objectClass) {
+
+        return $this->cache->get($cacheKey, function (ItemInterface $item) use ($objectClass) {
             return $this->parser->getPropertiesMetadata(new \ReflectionClass($objectClass));
         }, 0);
-
-        return $this->objectsMetadata[$objectClass];
     }
 
     /**