Merge pull request #318 from sir-gon/develop

sir-gon · web-flow · commit 9e950c9b3a35 · 2025-03-24T16:08:12.000-03:00
Develop
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -21,7 +21,7 @@ jobs:
       fail-fast: false
       matrix:
         os: ["windows-2022", "ubuntu-24.04", "macos-14"]
-        go: ['1.22.x', '1.23.x']
+        go: ['1.22.x', '1.23.x', '1.24.x']
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
@@ -44,10 +44,10 @@ jobs:
         run: go vet -v ./...
 
       - name: Lint golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
           args: --timeout=10m
-          version: v1.60.3
+          version: v2.0.0
           skip-cache: true
 
       - name: Test
diff --git a/exercises/hackerrank/interview_preparation_kit/arrays/crush.go b/exercises/hackerrank/interview_preparation_kit/arrays/crush.go
@@ -8,7 +8,7 @@ func arrayManipulation(n int32, queries [][]int32) int64 {
 	// why adding 2?
 	//   first slot to adjust 1-based index and
 	//   last slot for storing accumSum result
-	var LENGTH int32 = n + 2
+	var LENGTH = n + 2
 	const InitialValue int64 = 0
 	var maximum int64 = 0
 
diff --git a/exercises/hackerrank/interview_preparation_kit/arrays/crush_bruteforce.go b/exercises/hackerrank/interview_preparation_kit/arrays/crush_bruteforce.go
@@ -7,7 +7,7 @@ package hackerrank
 import "slices"
 
 func arrayManipulationBruteForce(n int32, queries [][]int32) int64 {
-	var LENGTH int32 = n + 1
+	var LENGTH = n + 1
 	const InitialValue int64 = 0
 
 	result := make([]int64, LENGTH)
diff --git a/exercises/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2.go b/exercises/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2.go
@@ -5,7 +5,7 @@
 package hackerrank
 
 func minimumSwaps(arr []int32) int32 {
-	var size int32 = int32(len(arr))
+	var size = int32(len(arr))
 	var indexedGroup = make(map[int32]int32, size)
 	var swaps int32 = 0
 	var index int32 = 0
diff --git a/exercises/hackerrank/interview_preparation_kit/arrays/new_year_chaos.go b/exercises/hackerrank/interview_preparation_kit/arrays/new_year_chaos.go
@@ -1,5 +1,5 @@
 /**
- * @link Problem definition [[docs/hackerrank/interview_preparation_kit/arrays/new_year_chaos.md]]
+* @link Problem definition [[docs/hackerrank/interview_preparation_kit/arrays/new_year_chaos.md]]
  */
 
 package hackerrank
@@ -23,12 +23,12 @@ func minimumBribesCalculate(q []int32) (int32, error) {
 		position := i + 1
 
 		if value-int32(position) > NEW_YEAR_CHAOS_TOLERANCE {
-			// error strings should not be capitalized (ST1005)
-			//nolint:stylecheck
+			//lint:ignore ST1005 Given string is capitalized
+			//nolint:staticcheck
 			return 0, errors.New(tooChaoticError)
 		}
 
-		var fragment []int32 = q[min(max(value-NEW_YEAR_CHAOS_TOLERANCE, 0), int32(i)):i]
+		var fragment = q[min(max(value-NEW_YEAR_CHAOS_TOLERANCE, 0), int32(i)):i]
 
 		for _, k := range fragment {
 			if k > value {
diff --git a/exercises/projecteuler/helpers/product.go b/exercises/projecteuler/helpers/product.go
@@ -1,7 +1,7 @@
 package helpers
 
 func Product(numList []int) int {
-	var result int = 1
+	var result = 1
 
 	if len(numList) == 0 {
 		return 0
diff --git a/exercises/projecteuler/problem0008.go b/exercises/projecteuler/problem0008.go
@@ -17,7 +17,7 @@ const __BIT_SIZE__ = 32
 
 func Problem0008(numberInput string) int {
 
-	var max int = 0
+	var greatest = 0
 
 	var digitsSlice []int32
 	var bigNumSlice = strings.Split(numberInput, "")
@@ -41,12 +41,12 @@ func Problem0008(numberInput string) int {
 		var currentProduct = helpers.Product(digitsSet)
 		utils.Debug("Product beetwen %d and %d <%d> is: %d", i, i+interval, digitsSet, currentProduct)
 
-		if currentProduct > max {
-			max = currentProduct
+		if currentProduct > greatest {
+			greatest = currentProduct
 		}
 	}
 
-	utils.Info("Problem0008 => The the greatest product of %d consecutive digits is: %d", interval, max)
+	utils.Info("Problem0008 => The the greatest product of %d consecutive digits is: %d", interval, greatest)
 
-	return max
+	return greatest
 }
diff --git a/exercises/projecteuler/problem0010.go b/exercises/projecteuler/problem0010.go
@@ -13,7 +13,7 @@ func Problem0010(bottom int, top int) int {
 
 	var answer int
 
-	var primes []int = []int{2}
+	var primes = []int{2}
 
 	var i = bottom
 
diff --git a/exercises/projecteuler/problem0011.go b/exercises/projecteuler/problem0011.go
@@ -14,7 +14,7 @@ func Problem0011(matrix [][]int, interval int) (int, bool) {
 		return 0, true
 	}
 
-	var max int = 0
+	var greatest = 0
 
 	var quadrantSize = interval
 	var matrixLimit = len(matrix) - (interval - 1)
@@ -33,8 +33,8 @@ func Problem0011(matrix [][]int, interval int) (int, bool) {
 				diag1Acum *= matrix[i+k][j+k]
 				diag2Acum *= matrix[i+k][j+(quadrantSize-1)-k]
 
-				max = helpers.IntMax(diag1Acum, max)
-				max = helpers.IntMax(diag2Acum, max)
+				greatest = helpers.IntMax(diag1Acum, greatest)
+				greatest = helpers.IntMax(diag2Acum, greatest)
 
 				// reset lines
 				var verticalAcum = 1
@@ -46,14 +46,14 @@ func Problem0011(matrix [][]int, interval int) (int, bool) {
 					verticalAcum *= matrix[i+k][j+l]
 					horizontalAcum *= matrix[i+l][j+k]
 
-					max = helpers.IntMax(verticalAcum, max)
-					max = helpers.IntMax(horizontalAcum, max)
+					greatest = helpers.IntMax(verticalAcum, greatest)
+					greatest = helpers.IntMax(horizontalAcum, greatest)
 				}
 			}
 		}
 	}
 
-	utils.Info("Problem0011 max => %d", max)
+	utils.Info("Problem0011 greatest => %d", greatest)
 
-	return max, false
+	return greatest, false
 }
diff --git a/exercises/projecteuler/problem0014.go b/exercises/projecteuler/problem0014.go
@@ -15,7 +15,7 @@ func Problem0014(bottom int, top int) int {
 
 	for i := bottom; i < top; i += 1 {
 
-		var sequence []int = helpers.CollatzSequence(i)
+		var sequence = helpers.CollatzSequence(i)
 		utils.Debug("sequence of %d: %v", i, sequence)
 
 		if len(sequence) > len(maxSequence) {
diff --git a/exercises/projecteuler/problem0023.go b/exercises/projecteuler/problem0023.go
@@ -21,7 +21,7 @@ func Contains[T comparable](s []T, e T) bool {
 
 func Problem0023(underLimit int, superLimit int) int {
 
-	var abundantNumberList []int = []int{}
+	var abundantNumberList = []int{}
 
 	// Produce a list of abundant numbers below limit
 	for i := underLimit; i <= superLimit; i++ {
diff --git a/utils/LoadJSON.go b/utils/LoadJSON.go
@@ -19,7 +19,11 @@ func LoadJSON(filepath string, v any) ([]byte, error) {
 
 	// t.Log("Successfully Opened" + filepath)
 	// defer the closing of our jsonFile so that we can parse it later on
-	defer jsonFile.Close()
+	defer func() {
+		if cerr := jsonFile.Close(); cerr != nil {
+			fmt.Println("Error closing file:", cerr)
+		}
+	}()
 
 	// read our opened file as a byte array.
 	byteValue, _ := io.ReadAll(jsonFile)

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ const __BIT_SIZE__ = 32`
`17`	`17`
`18`	`18`	`func Problem0008(numberInput string) int {`
`19`	`19`
`20`		`- var max int = 0`
	`20`	`+ var greatest = 0`
`21`	`21`
`22`	`22`	`var digitsSlice []int32`
`23`	`23`	`var bigNumSlice = strings.Split(numberInput, "")`
`@@ -41,12 +41,12 @@ func Problem0008(numberInput string) int {`
`41`	`41`	`var currentProduct = helpers.Product(digitsSet)`
`42`	`42`	`utils.Debug("Product beetwen %d and %d <%d> is: %d", i, i+interval, digitsSet, currentProduct)`
`43`	`43`
`44`		`- if currentProduct > max {`
`45`		`- max = currentProduct`
	`44`	`+ if currentProduct > greatest {`
	`45`	`+ greatest = currentProduct`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`49`		`- utils.Info("Problem0008 => The the greatest product of %d consecutive digits is: %d", interval, max)`
	`49`	`+ utils.Info("Problem0008 => The the greatest product of %d consecutive digits is: %d", interval, greatest)`
`50`	`50`
`51`		`- return max`
	`51`	`+ return greatest`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ func Problem0011(matrix [][]int, interval int) (int, bool) {`
`14`	`14`	`return 0, true`
`15`	`15`	`}`
`16`	`16`
`17`		`- var max int = 0`
	`17`	`+ var greatest = 0`
`18`	`18`
`19`	`19`	`var quadrantSize = interval`
`20`	`20`	`var matrixLimit = len(matrix) - (interval - 1)`
`@@ -33,8 +33,8 @@ func Problem0011(matrix [][]int, interval int) (int, bool) {`
`33`	`33`	`diag1Acum *= matrix[i+k][j+k]`
`34`	`34`	`diag2Acum *= matrix[i+k][j+(quadrantSize-1)-k]`
`35`	`35`
`36`		`- max = helpers.IntMax(diag1Acum, max)`
`37`		`- max = helpers.IntMax(diag2Acum, max)`
	`36`	`+ greatest = helpers.IntMax(diag1Acum, greatest)`
	`37`	`+ greatest = helpers.IntMax(diag2Acum, greatest)`
`38`	`38`
`39`	`39`	`// reset lines`
`40`	`40`	`var verticalAcum = 1`
`@@ -46,14 +46,14 @@ func Problem0011(matrix [][]int, interval int) (int, bool) {`
`46`	`46`	`verticalAcum *= matrix[i+k][j+l]`
`47`	`47`	`horizontalAcum *= matrix[i+l][j+k]`
`48`	`48`
`49`		`- max = helpers.IntMax(verticalAcum, max)`
`50`		`- max = helpers.IntMax(horizontalAcum, max)`
	`49`	`+ greatest = helpers.IntMax(verticalAcum, greatest)`
	`50`	`+ greatest = helpers.IntMax(horizontalAcum, greatest)`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`- utils.Info("Problem0011 max => %d", max)`
	`56`	`+ utils.Info("Problem0011 greatest => %d", greatest)`
`57`	`57`
`58`		`- return max, false`
	`58`	`+ return greatest, false`
`59`	`59`	`}`