Skip to content

feat(cli): add init provider flag#5

Closed
terminalchai wants to merge 1 commit into
skrun-dev:mainfrom
terminalchai:feature/cli-init-provider-flag
Closed

feat(cli): add init provider flag#5
terminalchai wants to merge 1 commit into
skrun-dev:mainfrom
terminalchai:feature/cli-init-provider-flag

Conversation

@terminalchai

Copy link
Copy Markdown

Summary

  • add a --provider flag to skrun init and map it to the default model for each supported provider
  • skip the interactive model prompt when --provider is supplied while still letting --model take precedence
  • document the new init flow and cover it with CLI package tests

Testing

  • pnpm build
  • pnpm test
  • pnpm exec biome check README.md docs/cli.md packages/cli/src/commands/init.ts packages/cli/src/commands/init.test.ts packages/cli/src/utils/prompts.ts

@Tarcroi

Tarcroi commented Mar 30, 2026

Copy link
Copy Markdown

Thanks for the PR! Looking good at first glance — will review in detail later this week.

@Tarcroi

Tarcroi commented Apr 12, 2026

Copy link
Copy Markdown

Apologies for the slow response — we were heads-down on Phase 2 features. Your PR is very welcome and we want to merge it. We just need a rebase on latest main since the codebase has changed quite a bit. Thanks for your patience!

@Tarcroi

Tarcroi commented Jun 7, 2026

Copy link
Copy Markdown

Hi @terminalchai — thank you for this PR, and apologies for the slow response! 🙏

We've decided not to add a standalone --provider flag. skrun init already supports non-interactive provider + model selection through --model <provider>/<name> (e.g. skrun init --model anthropic/claude-sonnet-4-6), which covers the same use case — so a separate --provider flag would be redundant with the current surface, and we'd like to keep the CLI minimal.

Really appreciate the effort, and the other PRs you've opened. Closing this PR and the linked issue (#1) — please don't let it put you off future contributions. 🙌

@Tarcroi Tarcroi closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants