Skip to content

[ENH] Implementing D2 data module, tests and TimeXer model from tslib for v2 #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 186 commits into from
Jun 20, 2025
Merged

[ENH] Implementing D2 data module, tests and TimeXer model from tslib for v2 #1836

merged 186 commits into from
Jun 20, 2025

Conversation

PranavBhatP
Copy link
Contributor

@PranavBhatP PranavBhatP commented May 15, 2025 •
edited
Loading

Description

This PR fixes issue #1833.

This PR involves the following changes:

  • New dataset and datamodule for tslib - link
  • Implementation of TimeXer with new data module. - link
  • Base class implementation of a TslibBaseModel - link.
  • Tests for the tslib data module. - link
  • Example notebook - link
  • Restructure codebase to include a layers directory for module containing architectural deep learning layer classes.
  • Metadata container for _timexer.py using the v2 framework - link

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

fkiraly and others added 30 commits February 22, 2025 23:18
@fkiraly
test suite
b3644a6
@fkiraly
Merge branch 'main' into test-suite
a1d64c6
@fkiraly
skeleton
4b2486e
@fkiraly
skeleton
02b0ce6
@fkiraly
Update test_all_estimators.py
41cbf66
@fkiraly
Update _base_object.py
cef62d3
@fkiraly
Update _lookup.py
bc2e93b
@fkiraly
Update _lookup.py
eee1c86
@fkiraly
base metadatda
164fe0d
@fkiraly
registry
20e88d0
@fkiraly
fix private name
318c1fb
@fkiraly
Update _base_object.py
012ab3d
@fkiraly
test failure
86365a0
@fkiraly
Update test_all_estimators.py
f6dee46
@fkiraly
Update test_all_estimators.py
9b0e4ec
@fkiraly
Update test_all_estimators.py
7de5285
@fkiraly
test folders
57dfe3a
@fkiraly
Update test.yml
c9f12db
@fkiraly
test integration
fa8144e
@fkiraly
fixes
232a510
@fkiraly
Update _conftest.py
1c8d4b5
@fkiraly
try scenarios
f632e32
@phoeenniixx
D1, D2 layer commit
252598d
@phoeenniixx
remove one comment
d0d1c3e
@phoeenniixx
model layer commit
80e64d2
@phoeenniixx
update docstring
6364780
@phoeenniixx
Merge branch 'refactor-d1-d2' into refactor-model
82b3dc7
@phoeenniixx
update data_module.py
257183c
@phoeenniixx
update data_module.py
9cdcb19
@phoeenniixx
Merge branch 'refactor-d1-d2' into refactor-model
a83bf32
PranavBhatP
PranavBhatP commented Jun 13, 2025
View reviewed changes
@fkiraly fkiraly added enhancement New feature or request labels Jun 18, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented Jun 19, 2025

is this ready to review?

@PranavBhatP
Copy link
Contributor Author

PranavBhatP commented Jun 19, 2025 •
edited
Loading

is this ready to review?

yes, it has been for a while.

@PranavBhatP PranavBhatP requested a review from agobbifbk June 19, 2025 14:18
fkiraly
fkiraly approved these changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me - I suppose we will run into issues when we make the output format more stringent, but that is best left to a separate PR.

Nice!

@fkiraly fkiraly merged commit 33041c7 into sktime:main Jun 20, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from PR under review to Done in May - Sep 2025 mentee projects Jun 20, 2025
@PranavBhatP PranavBhatP mentioned this pull request Jun 23, 2025
Closed
fkiraly pushed a commit that referenced this pull request Jun 23, 2025
@PranavBhatP
[ENH] DLinear model from tslib (#1874)
b2cfc14 
### Description

This PR works on issue #1869 to implement `DLinear` from `tslib`. Stacks
on #1836 and #1841.

Files to review (just pointing this out since there's a lot of files in
the stack, not relevant to this PR).
- dlinear model -
[link](https://github.com/sktime/pytorch-forecasting/blob/7f0495d6875ce918a9ffca1bb1ea895313ec81bb/pytorch_forecasting/models/dlinear/_dlinear.py)
- layers -
[link](https://github.com/sktime/pytorch-forecasting/blob/7f0495d6875ce918a9ffca1bb1ea895313ec81bb/pytorch_forecasting/layers/decomposition/_series_decomp.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoeenniixx phoeenniixx phoeenniixx left review comments

@fkiraly fkiraly fkiraly approved these changes

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@fnhirwa fnhirwa Awaiting requested review from fnhirwa fnhirwa is a code owner

@jdb78 jdb78 Awaiting requested review from jdb78 jdb78 is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

@agobbifbk agobbifbk Awaiting requested review from agobbifbk

Assignees

@PranavBhatP PranavBhatP

Labels
enhancement New feature or request
Projects
May - Sep 2025 mentee projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PranavBhatP @agobbifbk @fkiraly @phoeenniixx @pranavvp16