[ENH] Added metadata Testing for models and data modules for ptf-v2#1973
[ENH] Added metadata Testing for models and data modules for ptf-v2#1973ParamThakkar123 wants to merge 1 commit intosktime:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1973 +/- ##
=======================================
Coverage ? 87.04%
=======================================
Files ? 158
Lines ? 9354
Branches ? 0
=======================================
Hits ? 8142
Misses ? 1212
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
left a comment
There was a problem hiding this comment.
Thanks, interesting idea!
I am a bit confused about the logic here. I assume that you intend the new test test_d2_metadata to retrieve the new classes that you added, but this will not happen? Since the object_pkg variable will be, for instance, TimeXer_pkg_v2, but that class will never have the check method?
Design-wise, I think the best place to locate the checker method is imo not the model package class, but the D2 layer data class that produces the metadata?
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This Pull request adds metadata testing for models and data modules for
ptf-v2. I have addedConfigBasefor theEncoderDecoderTimeSeriesDataModuleand theTslibDataModule. Added new classes specific to each of data modules like for models usingEncoderDecoderTimeSeriesDataModuleI addedEncoderDecoderConfigBaseand forTslibDataModuleI addedTslibConfigBaseWhat should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes, All tests passes locally
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files