Skip to content

document conda environment behavior and consider not enabling conda in AWS custom AMIs #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SeungjinYang opened this issue Apr 24, 2025 · 0 comments
Assignees

Comments

@SeungjinYang
Copy link
Collaborator

SeungjinYang commented Apr 24, 2025

source : #5303 (comment)

While working on #5303 (comment), it's become apparent that we don't really document what conda environment is set up where (and why), and it is quite confusing to navigate it.

The fix to #4814 and #5265 involved deactivating conda environment that we activate if the image is a docker image. Do we need to do that, or can we get away with not activating the conda environment in the first place? I don't know, and I didn't want to tackle it in that PR - so here is the ticket to track this work.

Another question to consider - users don't expect conda environments to be set by us when using docker images, because the point of using a docker image is that they already have the environment they want and we should not modify it. Does the similar logic apply to custom AMIs in AWS, and in that case, should we apply a similar behavior for custom AMIs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant