Skip to content

Fix type error by unpacking tuple in get_all_managed_jobs #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

Fix type error by unpacking tuple in get_all_managed_jobs #6994

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
311c901
fix: unpack tuple to return only filtered_jobs in get_all_managed_jobs
seongsukwon-moreh Sep 3, 2025
08b8ffc
fix: add temporary values to mock_queue return for tuple unpacking
seongsukwon-moreh Sep 3, 2025
262ed9d
fix: add return type for the get_all_clusters and get_all_managed_job…
seongsukwon-moreh Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sky/utils/resource_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,10 @@ def get_all_managed_jobs():
# pylint: disable=import-outside-toplevel
from sky.jobs.server import core as managed_jobs_core
try:
return managed_jobs_core.queue(refresh=False,
skip_finished=True,
all_users=True)
filtered_jobs, _, _, _ = managed_jobs_core.queue(refresh=False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seongsukwon-moreh, could you please help add return type List[Dict[str, Any]] for the get_all_clusters and get_all_managed_jobs functions, so that any mismatch changes can be caught later?
Thanks!

skip_finished=True,
all_users=True)
return filtered_jobs
except exceptions.ClusterNotUpError:
logger.warning('All jobs should be finished.')
return []
Expand Down
Loading