make properties explicitly nullable #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krb19xx
changed the title
maartenpaauw
changed the title
|
@krb19xx thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently upgraded to PHP v8.4.5 and got an error when trying to post msgs using
chatPostMessage().Error message was:
SlackPhp\\BlockKit\\Kit::file(): Implicitly marking parameter $externalId as nullable is deprecated, the explicit nullable type must be used insteadI think the fix is to change line 123 in Kit.php from:
string $externalId = null,to:
?string $externalId = null,I realize this may only be one of many issues related to PHP v4.4 compatibility, but this is the one that I ran into.