Skip to content

Conversation

dd0ke
Copy link

@dd0ke dd0ke commented Jan 31, 2025

Added preliminary support for the creation of routes in alternative route tables on Linux, and using default routes via Nebula.
Nebula would crash anytime a default route was added or modified, regardless of the default route being added on to a separate table.

Requires new config param:

Specify the alternative routing table for created routes.

If unset, defaults to main routing table.

#alternative_routing_table: "my_alt_table"

Copy link

Thanks for the contribution! Before we can merge this, we need @dd0ke to sign the Salesforce Inc. Contributor License Agreement.

}

// If it's not a number, look up the table name in /etc/iproute2/rt_tables
content, err := os.ReadFile("/etc/iproute2/rt_tables")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location of this file seems like it could be distro-specific. Should it be configurable? Can the information instead be obtained via netlink or /proc?

dst = netip.PrefixFrom(netip.IPv4Unspecified(), 0)
} else {
if x := r.Dst.IP.To4(); x == nil {
// Nebula only handles ipv4 on the overlay currently
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is technically true, but #6 for IPv6 overlay support is gonna merge any day now!

@johnmaguire
Copy link
Collaborator

Hi @dd0ke - it's been a minute, so I wanted to touch base. We recently landed #1331 which may solve your needs. If not, could you share a bit about why you still prefer this approach? Additionally, I see there is some open review feedback. Are you still working on this PR?

@dd0ke
Copy link
Author

dd0ke commented Apr 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants