More LLR recaftoring: Refactor the PropertyReference #9907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Nov 5, 2025
Member
tronical
left a comment
tronical
left a comment
There was a problem hiding this comment.
Those two being mangled together always bothered me a little, so I welcome the separation.
ogoffart
force-pushed
the
olivier/compiler
branch
from
e6ca394 to
a843ba2
Compare
In preparation to have callback and properties in different vector
As this goes for property, function, callback
The idea is that we want to be able to get a scope without borrowing the llr::Compilation unit so we can have mutable borrow to the compilation unit
ogoffart
force-pushed
the
olivier/compiler
branch
from
e4bb2c9 to
fa3f9bc
Compare
tronical
approved these changes
Nov 11, 2025
ogoffart
force-pushed
the
olivier/compiler
branch
2 times, most recently
from
3d368a1 to
9813c33
Compare
Because they could be aliases to global
ogoffart
force-pushed
the
olivier/compiler
branch
from
9813c33 to
39671ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to "simplify" things. I don't know if that works
But the idea is that i would like to split the properties and callback into different arrays because having indexes specific for properties and callback makes things easier for a LLR based interpreter.