Implement slog::Value for std::sync::LazyLock #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This impl allows using `LazyLock` like an `FnValue`. The notable difference is that `LazyLock` memoizes the function's result, whereas `FnValue` generates a fresh result every time. This is relevant when values are stored in a `Logger` for multiple log calls. Closes slog-rs#360
No reason to do one and not the other.
Techcable
requested changes
Oct 11, 2025
Techcable
requested changes
Oct 11, 2025
Whoops. This is my fault :)
This is clearer.
Techcable
approved these changes
Oct 11, 2025
|
Thank you! I will squash & merge this before the v2.9.0 release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl allows using
LazyLocklike anFnValue. The notable difference is thatLazyLockmemoizes the function's result, whereasFnValuegenerates a fresh result every time. This is relevant when values are stored in aLoggerfor multiple log calls.Closes #360