Skip to content

Conversation

@keram88
Copy link
Contributor

@keram88 keram88 commented Jul 1, 2022

This PR addresses the following:

  • Improves path manipulation in regtest.py to be more compatible with macOS (based on work by @shaobo-he)
  • Extends the expected name for bc files generated by cargo to support an optional 16 digit hash

Co-authored-by: @shaobo-he

@keram88 keram88 requested review from shaobo-he and zvonimir July 1, 2022 20:26
Copy link
Member

@zvonimir zvonimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakamaric
Copy link
Collaborator

@keram88 so something is failing in regtest.py. It seems that it is maybe not opening config file properly or something like that. Could you please debug this? See the failing CI.

Copy link
Member

@zvonimir zvonimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zvonimir zvonimir merged commit a6c71fc into smackers:develop Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants