[Bug]: Github OAuth Console errors too quickly

[rmb938]

Steps to Reproduce

$ step oauth --provider github --client-id ${github-app-client-id} --console

Your Environment

• OS - Fedora 40
• step CLI Version -

Smallstep CLI/0.28.2 (linux/amd64)
Release Date: 2024-11-20T19:14:16Z

Expected Behavior

The CLI to not error and wait an appropriate amount of time

Actual Behavior

$ step oauth --provider github --client-id ${github-app-client-id} --console
Visit https://github.com/login/device and enter the code:
5008-218F
{
  "access_token": "",
  "id_token": "",
  "refresh_token": "",
  "expires_in": 0,
  "token_type": "",
  "error": "authorization_pending",
  "error_description": "The authorization request is still pending."
}

This returns after 5 seconds, which isn't enough time to open the browser and enter the code.

Additional Context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[rmb938]

According to https://docs.github.com/en/enterprise-cloud@latest/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-user-access-token-for-a-github-app

Until the user enters the code, GitHub will respond with a 200 status and an error response query parameter. So it needs to check if the error is authorization_pending and retry.