Skip to content

Parameters --cert-not-after and --cert-not-before of step ca token for non-ssh certificates #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PreterPant opened this issue Apr 16, 2025 · 1 comment · May be fixed by #1432
Open
Labels
enhancement needs triage Waiting for discussion / prioritization by team

Comments

@PreterPant
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The documentation states that the parameters --cert-not-after and --cert-not-before of step ca token are only supported on SSH certificates. Those options would be very helpful for x509 certificates as well.

Question is, if the documentation on this is even correct, since it was raised in #1065 under (2) that the code might work for certificates other then ssh.

Why is this needed?

If you issue one time tokens to third party to enroll for a certificate, it would be desireable to be able to enforce a certificate runtime lower then the maximum allowed runtime. Since the redeeming of the token would not happen in a controlled environment, the restriction would best be baked into the token to be handled by the server. Thus allowing a provisioner to have a higher max for some tokens.

@PreterPant PreterPant added enhancement needs triage Waiting for discussion / prioritization by team labels Apr 16, 2025
@alvidofaisal alvidofaisal linked a pull request May 31, 2025 that will close this issue
@alvidofaisal
Copy link

Hi @PreterPant,

I've created a pull request that adds support for the --cert-not-before and --cert-not-after flags for X.509 certificates in the step ca token command.

You can find the PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants