Prefer VerificationURIComplete if present #1430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the OIDC Device Authorization Flow in command/oauth, present the user with VerificationURIComplete rather than VerificationURI if present, so that the user doesn't have to manually type the code when using an IdP that provides this feature. Fixes smallstep#1424
github-actions
bot
added
the
needs triage
|
I don't have any tests; if this change isn't too small to warrant test coverage I'll need help adding those as I haven't worked with test frameworks before and have barely worked with Go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Prefer VerificationURIComplete if present
Pain or issue this feature alleviates:
In the OIDC Device Authorization Flow in command/oauth, present the user with VerificationURIComplete rather than VerificationURI if present, so that the user doesn't have to manually type the code when using an IdP that provides this feature.
Is there documentation on how to use this feature? If so, where?
No, the feature is automatically used if supported by the IdP
In what environments or workflows is this feature supported?
The OIDC Device Authorization Flow with an IdP that provides the
verification_uri_completeparameter (e.g. Keycloak)Supporting links/other PRs/issues:
Fixes #1424
💔Thank you!