Skip to content

squash interface changes and imports#1862

Open
patricios-space wants to merge 10 commits intomainfrom
sqash/testadapter-interface-update
Open

squash interface changes and imports#1862
patricios-space wants to merge 10 commits intomainfrom
sqash/testadapter-interface-update

Conversation

@patricios-space
Copy link
Contributor

No description provided.

tt-cll
tt-cll previously approved these changes Mar 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates module dependencies and the TestAdapter contract to align with newer deployment/test adapter behavior across CCIP components.

Changes:

  • Bump github.com/smartcontractkit/chainlink-ccip/deployment dependency version across several modules/go.sum files.
  • Modify devenv and chain deployment module go.mod files to adjust/disable local replace wiring and pin explicit deployment-related versions.
  • Expand and change the deployment/testadapters.TestAdapter interface (new methods + breaking signature changes).

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
integration-tests/go.mod Bumps chainlink-ccip/deployment version used by integration-tests module.
devenv/go.mod Comments out local replace for chainlink-ccip/deployment and adds explicit require pins for deployment submodules.
devenv/go.sum Adds sums for the new chainlink-ccip/deployment pseudo-version.
deployment/testadapters/adapters.go Breakingly changes TestAdapter interface (new methods + renamed/reshaped methods).
chains/solana/deployment/go.mod Updates required versions and comments out local replace for chainlink-ccip/deployment.
chains/solana/deployment/go.sum Adds sums for the new chainlink-ccip/deployment pseudo-version.
chains/evm/deployment/go.mod Updates deployment dependency version and comments out local replace for chainlink-ccip/deployment.
chains/evm/deployment/go.sum Adds sums for the new chainlink-ccip/deployment pseudo-version.
ccv/chains/evm/deployment/go.mod Bumps chainlink-ccip/deployment dependency version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smartcontractkit smartcontractkit deleted a comment from Copilot AI Mar 25, 2026
@smartcontractkit smartcontractkit deleted a comment from Copilot AI Mar 25, 2026
@smartcontractkit smartcontractkit deleted a comment from Copilot AI Mar 25, 2026
@smartcontractkit smartcontractkit deleted a comment from Copilot AI Mar 25, 2026
@smartcontractkit smartcontractkit deleted a comment from Copilot AI Mar 25, 2026
@smartcontractkit smartcontractkit deleted a comment from Copilot AI Mar 25, 2026
krebernisak
krebernisak previously approved these changes Mar 25, 2026
matYang
matYang previously approved these changes Mar 25, 2026
@patricios-space patricios-space added this pull request to the merge queue Mar 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026
@patricios-space patricios-space dismissed stale reviews from matYang, krebernisak, and tt-cll via b7823e8 March 25, 2026 21:26
// github.com/smartcontractkit/chainlink-testing-framework/framework => ../../chainlink-testing-framework/framework
)

require (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should not be a separate block, why have these moved out?

replace github.com/fbsobreira/gotron-sdk => github.com/smartcontractkit/chainlink-tron/relayer/gotron-sdk v0.0.4

replace github.com/smartcontractkit/chainlink-ccip/deployment => ../../../deployment
// replace github.com/smartcontractkit/chainlink-ccip/deployment => ../../../deployment // TODO: uncomment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR provides no context on why this is commented and the TODO also ins't clear

@github-actions
Copy link

Metric sqash/testadapter-interface-update main
Coverage 70.1% 69.9%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants