Add MetaClient verification #188
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunkRat
reviewed
Aug 19, 2025
Comment on lines
235
to
240
| info := params["info"] | ||
| if len(info) != 2 { | ||
| return nil, fmt.Errorf("incorrect size for info: %v", info) | ||
| } | ||
| to := common.HexToAddress(info[0]) // metacall address | ||
| dApp := common.HexToAddress(info[1]) |
There was a problem hiding this comment.
Are we sure that an array of strings is the best design here? The worry about this design is that the positional requirements in the array are hard to validate and track across deployment systems and tooling.
One alternative could be to use a TOML table with named params for to and dApp, maybe like the below?
[relayConfig.dualTransmission.meta.info]
to = "0x000000..." # metacall address
dApp = "0x000000..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.