lesson-15 nftMarketplace.sol tests failed.

[TimeKeyRoll]

Does anyone know about this Error?

repo- https://github.com/TimeKeyRoll/hardhat-nft-marketplace.git

[alymurtazamemon]

@TimeKeyRoll Your custom errors do not match with the errors that are reverting from the contract.

For example, this is your function;

function listItem(
    address nftAddress,
    uint256 tokenId,
    uint256 price
)
    external
    notListed(nftAddress, tokenId, msg.sender)
    isOwner(nftAddress, tokenId, msg.sender)
{
    if (price <= 0) {
        revert NftMarketplace__PricemustbeAboveZero();
    }
    IERC721 nft = IERC721(nftAddress);

    if (nft.getApproved(tokenId) != address(this)) {
        revert NftMarketplace__NotApprovedForMArketPlace();
    }
    s_listings[nftAddress][tokenId] = Listing(price, msg.sender);
    emit ItemListed(msg.sender, nftAddress, tokenId, price);
}

here you can check what custom errors you are reverting.

Similarly, here you are expecting to revert an error when listing is not available;

it("reverts if there is no listing", async function () {
    const error = `NftMarketplace__NotListed("${basicNft.address}", ${TOKEN_ID})`
    await expect(
        NftMarketplace.cancelListing(basicNft.address, TOKEN_ID)
    ).to.be.revertedWithCustomError(NftMarketplace, error)
})

But here you did not revert any custom error;

function cancelListing(address nftAddress, uint256 tokenId)
    external
    isOwner(nftAddress, tokenId, msg.sender)
    isListed(nftAddress, tokenId)
{
    delete (s_listings[nftAddress][tokenId]);
    emit ItemCancelled(msg.sender, nftAddress, tokenId);
}

[TimeKeyRoll]

I am not sure what do you even mean? they both have been added with customError but both are getting failed and also different to each other. Not sure what went wrong and how it could be fixed?

[TimeKeyRoll]

@abossofmyself

[RoboCrypter]

@TimeKeyRoll : Let me check!

[TimeKeyRoll]

Perfect

[RoboCrypter]

@TimeKeyRoll : The reason why those tests of you are failing, Is because you are using revertedWithCustomError is those tests, instead of just using revertedWith because those const error = were made for revertedWith.

If you wanna use revertedWithCustomError in the revert statements of your ItemListed and ItemCancelled tests,

Do not use the const error = but instead just type or paste the error name after the contract argument, It will be sufficient :

( in ItemListed test ) From this :

await expect(
                      NftMarketplace.listItem(basicNft.address, TOKEN_ID, PRICE)
                  ).to.be.revertedWithCustomError(NftMarketplace, error)

• To this :

await expect(
                      NftMarketplace.listItem(basicNft.address, TOKEN_ID, PRICE)
                  ).to.be.revertedWithCustomError(NftMarketplace, "NftMarketplace__AlreadyListed")

( in your cancelledItem test ) From this :

await expect(
                      NftMarketplace.cancelListing(basicNft.address, TOKEN_ID)
                  ).to.be.revertedWithCustomError(NftMarketplace, error)

• To this :

await expect(
                      NftMarketplace.cancelListing(basicNft.address, TOKEN_ID)
                  ).to.be.revertedWithCustomError(NftMarketplace, "NftMarketplace__NotListed")

It should resolve your issue!

Let me know, If the issue persists...

[TimeKeyRoll]

@abossofmyself thankyou very much for the reply. sorry it took me a while to reply since i was away and yes it has fixed the issue. many thanks :)

[allwin199]

await expect(nftMarketplace.listItem(basicNft.address, TOKEN_ID, PRICE))
                      .to.be.revertedWithCustomError(
                          nftMarketplaceContract,
                          "NftMarketplace__AlreadyListed"
                      )
                      .withArgs(basicNft.address, TOKEN_ID);

use .withArgs to pass all the args that comes with the custom error