src/screens/Job: add CCIPSpec toml rendering #100
Draft
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for CCIPSpec TOML rendering in the operator UI.
- Modifies the job definition generator to handle CCIPSpec.
- Introduces a test case verifying the CCIPSpec definition output.
- Updates the GraphQL query in the JobView component and adds an accompanying changeset.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/screens/Job/generateJobDefinition.ts | Adds CCIPSpec case to merge job and spec fields for TOML output. |
| src/screens/Job/generateJobDefinition.test.ts | Adds test case for validating the generated CCIPSpec definition. |
| src/screens/Job/JobView.tsx | Extends the GraphQL query to fetch additional CCIPSpec fields. |
| .changeset/silent-turkeys-deny.md | Provides the changeset for a minor operator-ui release. |
Comments suppressed due to low confidence (2)
src/screens/Job/generateJobDefinition.ts:295
- Confirm that using 'CCIPSpec' for branch selection is intentional and clearly distinguishes between job.type and spec.__typename if both exist. This will help maintain consistency and reduce potential confusion.
case 'CCIPSpec':
src/screens/Job/JobView.tsx:151
- Review the new fields (p2pv2Bootstrappers and relayConfigs) included in the CCIPSpec fragment to ensure they are consistent with the data rendered in the TOML output by generateJobDefinition. Confirm that these additional fields are required in the UI logic.
... on CCIPSpec {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CCIPSpec toml rendering to the operator UI.
Steps to Test
yarn testChecklist
If this PR creates changes to the operator-ui itself, rather than tests, pipeline changes, etc. Then please create a changeset so that a new release is created, and the changelog is updated. See: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md#what-is-a-changeset