Fix/incorrect setting service status #3106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGapchuk
force-pushed
the
fix/incorrect_setting_service_status
branch
from
7acf7f4 to
ade53aa
Compare
alexkutsan
suggested changes
Oct 30, 2019
| bool result, | ||
| std::vector<std::string>& rejected_params) OVERRIDE; | ||
|
|
||
| bool SetNaviServiceStatus(uint32_t connection_key, |
|
|
||
| NaviServiceStatusMap::iterator it = navi_service_status_.find(app_id); | ||
| if (navi_service_status_.end() == it) { | ||
| if (navi_service_status_.end() == it && !result) { |
There was a problem hiding this comment.
@IGapchuk not obvious what is result variable about. Please rename variable. Give more narative name
| bool ApplicationManagerImpl::SetNaviServiceStatus( | ||
| uint32_t connection_key, | ||
| protocol_handler::ServiceType service_type, | ||
| bool is_started) { |
There was a problem hiding this comment.
@IGapchuk good practice to use enums for such values.
|
|
||
| auto app = application(connection_key); | ||
| if (!app) { | ||
| LOG4CXX_DEBUG( |
There was a problem hiding this comment.
@IGapchuk I would say this is warning or error
| if (navi_service_status_.end() == it) { | ||
| LOG4CXX_WARN(logger_, | ||
| "No Information about navi service " << service_type); | ||
| NaviServiceStatusMap::iterator it = |
| NaviServiceStatusMap::iterator it = | ||
| navi_service_status_.find(app->app_id()); | ||
| if (navi_service_status_.end() == it && (is_started)) { | ||
| std::pair<NaviServiceStatusMap::iterator, bool> res = |
| utils::Optional<hmi_apis::Common_ServiceStatusUpdateReason::eType> | ||
| service_update_reason) = 0; | ||
|
|
||
| virtual bool SetNaviServiceStatus(uint32_t connection_key, |
IGapchuk
force-pushed
the
fix/incorrect_setting_service_status
branch
from
ade53aa to
40a8805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue number]
This PR is not ready for review.
Summary
[Summary of PR changes]
CLA