-
Notifications
You must be signed in to change notification settings - Fork 33
Description
We have an implementation using the Smarty JS SDK where were are utilizing the .withSender()
method on the ClientBuilder
class so that we can leverage some of our existing built in fetch observability.
Since the type of sender
is any
we don't have the type checking to know if we have the correct implementation here which caused an incorrect first pass.
Digging into this repo a bit deeper, we uncovered what we think is the proper way to utilize .withSender
, but the documentation is a bit sparse here. Essentially we're wrapping our internal fetch observability to conform with Smarty's expected interface. The problem is, we had to internally define Request
Response
and Sender
interfaces even though upon checking they seem to be defined internally here.
A full official TypeScript SDK would be amazing, but in the interim could we have the types mentioned above exposed in the JS SDK?