Skip to content

Conversation

tsamaya
Copy link
Contributor

@tsamaya tsamaya commented Feb 7, 2025

This change prevents the plugin to thow an error when the bounds attribute is absent from the API result

βœ… Closes: #421

This change prevents the plugin to thow an error when the `bounds`
attribute is absent from the API result

βœ… Closes: smeijer#421
@openbrian
Copy link

The PR looks good to me.

@ramazansancar ramazansancar self-requested a review February 8, 2025 15:05
@ramazansancar
Copy link
Collaborator

Thanks for the PR. Everything seems right. @tsamaya

image

@ramazansancar ramazansancar merged commit 75b60db into smeijer:main Feb 8, 2025
8 checks passed
@smeijer
Copy link
Owner

smeijer commented Feb 8, 2025

πŸŽ‰ This PR is included in version 4.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@smeijer
Copy link
Owner

smeijer commented Feb 8, 2025

Thanks @tsamaya and @ramazansancar! Appreciated.

@smeijer
Copy link
Owner

smeijer commented Feb 8, 2025

@all-contributors please add @tsamaya for code

Copy link
Contributor

@smeijer

I've put up a pull request to add @tsamaya! πŸŽ‰

@smeijer
Copy link
Owner

smeijer commented Feb 8, 2025

@all-contributors please add @ramazansancar for maintenance, review

Copy link
Contributor

@smeijer

I've put up a pull request to add @ramazansancar! πŸŽ‰

smeijer pushed a commit that referenced this pull request Feb 8, 2025
Adds @tsamaya as a contributor for code.

This was requested by smeijer [in this
comment](#422 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
smeijer pushed a commit that referenced this pull request Feb 8, 2025
…#424)

Adds @ramazansancar as a contributor for maintenance, review.

This was requested by smeijer [in this
comment](#422 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The OpenCage Provider does not always return attribute bounds
4 participants