fix: resolve TypeScript, Jest, and cross-platform compatibility issues #433
Conversation
- Add @types/leaflet@^1.9.20 to fix TS7016 module declaration errors - Fix Windows lint script compatibility by replacing single quotes with double quotes - Update TypeScript target from ES2015 to es2022 for modern language features - Add proper L.DragEndEvent type annotation to dragend event handler (type fix) - Modernize Jest configuration to resolve ts-jest deprecation warnings: * Remove deprecated globals.ts-jest configuration * Update transform syntax to array format with tsconfig property - Add Leaflet v1.9.0 to CI test matrix for latest version compatibility - Minor README formatting improvements and link fixes This resolves TypeScript compilation errors, Jest deprecation warnings, and Windows development environment issues.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses TypeScript compilation errors, Jest deprecation warnings, and cross-platform compatibility issues to improve the development environment and reduce build warnings.
- Adds proper TypeScript type annotations and required dependencies
- Modernizes Jest configuration to remove deprecation warnings
- Fixes Windows compatibility issues in npm scripts
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds @types/leaflet dependency and fixes Windows script compatibility |
| SearchControl.ts | Adds proper TypeScript type annotation for dragend event handler |
| bingResponse.json | Minor formatting change in test data |
| README.md | Improves formatting and fixes link case consistency |
| .github/workflows/ci.yml | Adds Leaflet v1.9.0 to CI test matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 9 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
smeijer
force-pushed
the
main
branch
10 times, most recently
from
acaaece to
f3de8ec
Compare
|
Thanks. Looks great! |
|
🎉 This PR is included in version 4.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This resolves TypeScript compilation errors, Jest deprecation warnings, and Windows development environment issues.