Skip to content

Add ability to use any 1D calibrated lamp as a template. #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ability to use any 1D calibrated lamp as a template. #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions goodman_pipeline/core/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3747,6 +3747,10 @@ def get_reference_lamp(self, header):
filtered_collection.file.to_string(
index=False))
self._ccd = CCDData.read(full_path, unit=u.adu)
if 'GSP_FNAM' not in self._ccd.header.keys():
self._ccd.header.set('GSP_FNAM',
value=os.path.basename(full_path),
comment='File name')
self._recover_lines()
return self._ccd
else:
Expand Down
10 changes: 5 additions & 5 deletions goodman_pipeline/spectroscopy/wavelength.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def __call__(self,
self.i_fig = None

log.info('Processing Science Target: '
'{:s}'.format(ccd.header['OBJECT']))
'{:s}'.format(ccd.header['OBJECT']))
if comp_list is not None:
wavelength_solutions = []
reference_lamp_names = []
Expand All @@ -155,7 +155,7 @@ def __call__(self,
self.lamp_name = self.lamp.header['OBJECT']

log.info('Processing Comparison Lamp: '
'{:s}'.format(self.lamp_name))
'{:s}'.format(self.lamp_name))

self.lines_center = get_lines_in_lamp(
ccd=self.lamp, plots=plots)
Expand Down Expand Up @@ -203,9 +203,9 @@ def __call__(self,

if len(wavelength_solutions) > 1:
log.warning("The current version of the pipeline does not "
"combine multiple solution instead it saves a "
"single version of the science file for each "
"wavelength solution calculated.")
"combine multiple solution instead it saves a "
"single version of the science file for each "
"wavelength solution calculated.")
for i in range(len(wavelength_solutions)):
# TODO (simon): Combine Multiple solutions
self.wsolution = wavelength_solutions[i]
Expand Down