Skip to content

Commit f0c2eaf

Browse files
llucaxibuclaw
andcommitted
Apply suggestions from code review by @ibucklaw
Co-authored-by: Iain Buclaw <ibuclaw@gdcproject.org>
1 parent 8ecebb9 commit f0c2eaf

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

relnotes/setup-pat.bug.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
### The `setup` comman will not attempt to login using user/password
1+
### The `setup` command will not attempt to login using user/password
22

3-
GitHub stopped supporting login using user/password with the API, so trying to
3+
GitHub stopped supporting logins using user/password with the API, so trying to
44
do so in the `setup` command is doomed to fail. Because of this, support for
55
generating a Personal Access Token (PAT) for the user is now removed. Instead
6-
the user has to create their own PAT manually and passing it to the `setup`
6+
the user has to create their own PAT manually and pass it to the `setup`
77
command instead.
88

99
In particular the `setup` command removed the `--password` option and added
10-
a `--oauthtoken` option instead, and when not specified, it will ask the user
10+
the `--oauthtoken` option instead, and when not specified, it will ask the user
1111
to create one (with some hints on how to do so).
1212

13-
**NOTE:** This would normally be a breaking change deserving a new major, but
13+
**NOTE:** This would normally be a breaking change deserving a new major release, but
1414
since the tool was *externally* broken, there is no way to fix it without
1515
breaking changes and previous versions will be **all broken**, so it doesn't
1616
make sense to make a major release for this change.

0 commit comments

Comments
 (0)