Skip to content

Conversation

@alxbilger
Copy link
Contributor

This is a final effort to fix the compilation of this plugin. Since it was not used and not updated for a long time, I suggest to archive it in another repository.

It compiles, but I did not test the components.

The only issue during the fixing process was in PersistentFrictionContact.inl. I could not fix the lines with o->baryCoords because it was removed in #1048. I added the following comment:

//baryCoord was removed in https://github.com/sofa-framework/sofa/pull/1048

Therefore, the component PersistentFrictionContact cannot work as before.

Fixes #5712


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unused variable

1 participant