-
Notifications
You must be signed in to change notification settings - Fork 12
Split text when larger than 512 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lfoppiano
wants to merge
52
commits into
softcite:master
Choose a base branch
from
lfoppiano:improvement/split-text-when-larger-than-512
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Split text when larger than 512 #47
lfoppiano
wants to merge
52
commits into
softcite:master
from
lfoppiano:improvement/split-text-when-larger-than-512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstram
…ntence before calling the first sequence-labelling model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People tend to use the POST to process Text as the easy way to use software-mentions, however when using the BERT models and sending the fulltext through that API is likely to get no results back.
This PR attempt to mitigate this issue, by splitting into sentences when the text is larger than 512 and the
software
model is using the DL model.NOTE that this change is chained with all the PR that I've been submitting before so you might want to merge those before. 😄