Skip to content

Conversation

@Aceeri
Copy link
Contributor

@Aceeri Aceeri commented Oct 22, 2018

If you did println!("{}", err); it would stack overflow because the Display impl recursively called Display::fmt on itself here

@Aceeri Aceeri force-pushed the error-stackoverflow branch from b6771cb to 9215c3e Compare October 22, 2018 23:58
@ufoscout
Copy link

This issue is still present in the master branch and it causes a stack overflow if the credentials to connect to Jira are not valid.

Here a simple way to fix it:

change from:

writeln!(f, "Could not connect to Jira: {}!", self),

to:

writeln!(f, "Could not connect to Jira: {:?}!", self),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants