Skip to content

Fix stack overflow on display error #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix stack overflow on display error #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use reqwest::Error as HttpError;
use reqwest::StatusCode;
use serde_json::error::Error as SerdeError;
use std::io::Error as IoError;
use std::error::Error as StdError;

// Ours
use Errors;
Expand Down Expand Up @@ -57,12 +58,12 @@ impl ::std::fmt::Display for Error {
ref code,
ref errors,
} => writeln!(f, "Jira Client Error ({}):\n{:#?}", code, errors),
_ => writeln!(f, "Could not connect to Jira: {}!", self),
_ => writeln!(f, "Could not connect to Jira: {}", self.description()),
}
}
}

impl ::std::error::Error for Error {
impl StdError for Error {
fn description(&self) -> &str {
use Error::*;

Expand All @@ -77,7 +78,7 @@ impl ::std::error::Error for Error {
}
}

fn cause(&self) -> Option<&::std::error::Error> {
fn cause(&self) -> Option<&StdError> {
use Error::*;

match *self {
Expand Down