feat: Ref/Value behavior tracking #1755
Conversation
|
pkg.pr.new packages benchmark commit |
reference to something define in that function)
the value proxies
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
lursz and
reczkok
|
Something weird happened to the vaporrave example, some of the effects seem to have disappeared. Also, Slime Mold 3D throws when switching to another example, but this might have been the case before. |
apps/typegpu-docs/src/examples/simulation/stable-fluid/simulation.ts
Outdated
Show resolved
Hide resolved
apps/typegpu-docs/src/examples/simulation/stable-fluid/simulation.ts
Outdated
Show resolved
Hide resolved
|
|
||
| type AnyFn = (...args: never[]) => unknown; | ||
|
|
||
| function shallowEqualSchemas(a: AnyData, b: AnyData): boolean { |
There was a problem hiding this comment.
Different structs will be equal. I'd rename this, though I have no ideas right now
Co-authored-by: Aleksander Katan <56294622+aleksanderkatan@users.noreply.github.com>
Co-authored-by: Aleksander Katan <56294622+aleksanderkatan@users.noreply.github.com>
| } | ||
|
|
||
| return this.#value; | ||
| return schemaCallWrapper(this.dataType, this.#value); |
There was a problem hiding this comment.
I'm worried about the performance of this. Sometimes these constants are not insignificant in size, e.g. in cube-marching, I use a tgpu.const(d.arrayOf(d.u32, 256), ...). I don't use it on JS side, but still, if we allow that, it should not be unnecessarily slow.
|
|
||
| ctx.addDeclaration(`${fnAttribute}fn ${id}${header}${body}`); | ||
| return snip(id, returnType); | ||
| return snip(id, returnType, /* ref */ 'runtime'); |
There was a problem hiding this comment.
I'm a little hesitant about calling everything 'runtime' bu default, maybe we could find a more fitting name, like 'unknown'?
| return data; | ||
| } | ||
|
|
||
| export function toStorable(schema: AnyData): AnyData { |
There was a problem hiding this comment.
Could you add some docs to this? At a glance, I don't know what it does e.g. to atomic types.
Vaporrave looks fine to me, how does it look like for you? |
Sorry, I meant Disco New: Old: |
|
Docs have TGSL that is no longer valid |
2 participants
Changes:
conststatements be pointers if they take in a referential type (let statements)conststatements with naturally non-referential types to be WGSLconst🎉Reference assignment errors:
Invalid 'let' statement errors:
