Skip to content

Conversation

@aleksanderkatan
Copy link
Contributor

Changes:

  • replace old test example with a new one.

There is no resolve test because it times out, and the number of called resolves is really uncertain.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@c5a36e2923b68593b74309cfb34fff6e2d9576ab
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@c5a36e2923b68593b74309cfb34fff6e2d9576ab
https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@c5a36e2923b68593b74309cfb34fff6e2d9576ab

benchmark
view benchmark

commit
view commit

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces an old concurrent scan test example with comprehensive prefix scan tests. The changes introduce a new test suite that validates both scan and prefix scan operations with various edge cases and data sizes.

Key changes:

  • Complete replacement of the concurrent scan test with a comprehensive prefix scan test suite
  • Export of BinaryOp type from the prefix scan module
  • New helper functions for JavaScript-based reference implementations

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/typegpu-concurrent-scan/src/prefixScan.ts Exports BinaryOp type for external use
apps/typegpu-docs/src/examples/tests/prefix-scan/meta.json Updates test title from "Concurrent Scan Test" to "Prefix Scan Tests"
apps/typegpu-docs/src/examples/tests/prefix-scan/index.ts Adds comprehensive test suite with multiple test cases for scan and prefix scan operations
apps/typegpu-docs/src/examples/tests/prefix-scan/index.html Provides minimal HTML for test result display
apps/typegpu-docs/src/examples/tests/prefix-scan/functions.ts Implements helper functions including binary operations and JavaScript reference implementations
apps/typegpu-docs/src/examples/tests/concurrent-scan/index.ts Removes old concurrent scan test implementation
apps/typegpu-docs/src/examples/tests/concurrent-scan/index.html Removes old HTML for concurrent scan test

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

aleksanderkatan and others added 2 commits October 13, 2025 14:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aleksanderkatan aleksanderkatan requested a review from lursz October 13, 2025 13:23
@aleksanderkatan aleksanderkatan marked this pull request as ready for review October 13, 2025 13:23
Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant! Great work

Copy link
Collaborator

@cieplypolar cieplypolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎰 1 nit though, I would love to see shellless functions in ./functions.ts, but in order to do that base branch needs to be updated.

EDIT1:
Wait with merging I want to add vector and matrix tests :)

EDIT2:
Nevermind, BinaryOp signature won't allow me.

Copy link
Collaborator

@cieplypolar cieplypolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There exists round function in std 😉

Co-authored-by: Szymon Szulc <103948576+cieplypolar@users.noreply.github.com>
Copy link
Contributor

@lursz lursz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@lursz lursz merged commit 8b5b87d into feat/concurrent-sum-debug Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants