-
-
Notifications
You must be signed in to change notification settings - Fork 25
docs: Tests for prefix scan #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Tests for prefix scan #1804
Conversation
|
pkg.pr.new packages benchmark commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces an old concurrent scan test example with comprehensive prefix scan tests. The changes introduce a new test suite that validates both scan and prefix scan operations with various edge cases and data sizes.
Key changes:
- Complete replacement of the concurrent scan test with a comprehensive prefix scan test suite
- Export of
BinaryOptype from the prefix scan module - New helper functions for JavaScript-based reference implementations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/typegpu-concurrent-scan/src/prefixScan.ts | Exports BinaryOp type for external use |
| apps/typegpu-docs/src/examples/tests/prefix-scan/meta.json | Updates test title from "Concurrent Scan Test" to "Prefix Scan Tests" |
| apps/typegpu-docs/src/examples/tests/prefix-scan/index.ts | Adds comprehensive test suite with multiple test cases for scan and prefix scan operations |
| apps/typegpu-docs/src/examples/tests/prefix-scan/index.html | Provides minimal HTML for test result display |
| apps/typegpu-docs/src/examples/tests/prefix-scan/functions.ts | Implements helper functions including binary operations and JavaScript reference implementations |
| apps/typegpu-docs/src/examples/tests/concurrent-scan/index.ts | Removes old concurrent scan test implementation |
| apps/typegpu-docs/src/examples/tests/concurrent-scan/index.html | Removes old HTML for concurrent scan test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very elegant! Great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎰 1 nit though, I would love to see shellless functions in ./functions.ts, but in order to do that base branch needs to be updated.
EDIT1:
Wait with merging I want to add vector and matrix tests :)
EDIT2:
Nevermind, BinaryOp signature won't allow me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There exists round function in std 😉
Co-authored-by: Szymon Szulc <103948576+cieplypolar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Changes:
There is no resolve test because it times out, and the number of called resolves is really uncertain.