fix: clang-tidy warnings, naming, AQBase TEvent

Author: closetcaiman

packages/react-native-audio-api/common/cpp/audioapi/core/AudioParam.h

@@ -68,10 +68,10 @@ class AudioParam {
   /// @note Audio Thread only
   void cancelAndHoldAtTime(double cancelTime);
 
-  template <
-      typename F,
-      typename = std::enable_if_t<std::is_invocable_r_v<void, std::decay_t<F>, BaseAudioContext &>>>
-  bool scheduleAudioEvent(F &&event) noexcept {
+  template <typename F>
+  bool scheduleAudioEvent(F &&event) noexcept
+    requires(std::is_invocable_r_v<void, std::decay_t<F>, BaseAudioContext &>)
+  {
     if (std::shared_ptr<BaseAudioContext> context = context_.lock()) {
       return context->scheduleAudioEvent(std::forward<F>(event));
     }
@@ -140,6 +140,7 @@ class AudioParam {
   void updateQueue(RenderAutomationEvent &&event) {
     eventsQueue_.push(std::move(event));
   }
+
   float getValueAtTime(double time);
   void processInputs(
       const std::shared_ptr<DSPAudioBuffer> &outputBuffer,

packages/react-native-audio-api/common/cpp/audioapi/core/utils/automation/AutomationControlQueue.cpp

@@ -19,16 +19,16 @@ Result<NoneType, std::string> AutomationControlQueue::checkCurveExclusion(
               event.getStartTime(),
               event.getEndTime(),
               toString(conflict->getType()),
-              conflict->getAutomationEventTime()));
+              conflict->getAutomationTime()));
     }
   } else {
-    const auto *conflict = findEventAtTime(event.getAutomationEventTime());
+    const auto *conflict = findEventAtTime(event.getAutomationTime());
     if ((conflict != nullptr) && conflict->getType() == AutomationEventType::SET_VALUE_CURVE) {
       return Err(
           std::format(
               "Cannot schedule event of type {} at time {} because it conflicts with an existing curve event from time {} to {}.",
               toString(event.getType()),
-              event.getAutomationEventTime(),
+              event.getAutomationTime(),
               conflict->getStartTime(),
               conflict->getEndTime()));
     }
@@ -37,7 +37,7 @@ Result<NoneType, std::string> AutomationControlQueue::checkCurveExclusion(
 }
 
 void AutomationControlQueue::cancelScheduledValues(double cancelTime) {
-  while (!eventQueue_.isEmpty() && eventQueue_.peekBack().getAutomationEventTime() >= cancelTime) {
+  while (!eventQueue_.isEmpty() && eventQueue_.peekBack().getAutomationTime() >= cancelTime) {
     eventQueue_.popBack();
   }
 }
@@ -47,7 +47,7 @@ const AutomationEvent *AutomationControlQueue::findEventAtTime(double automation
   for (const auto &event : eventQueue_) {
     if ((event.getType() == AutomationEventType::SET_VALUE_CURVE &&
          event.getStartTime() <= automationTime && automationTime <= event.getEndTime()) ||
-        event.getAutomationEventTime() == automationTime) {
+        event.getAutomationTime() == automationTime) {
       return &event;
     }
   }

packages/react-native-audio-api/common/cpp/audioapi/core/utils/automation/AutomationEvent.hpp

@@ -35,7 +35,7 @@ class AutomationEvent {
     return *this;
   }
 
-  [[nodiscard]] double getAutomationEventTime() const noexcept {
+  [[nodiscard]] double getAutomationTime() const noexcept {
     return isRamp(type_) ? endTime_ : startTime_;
   }
 

packages/react-native-audio-api/common/cpp/audioapi/core/utils/automation/AutomationQueueBase.hpp

@@ -7,6 +7,10 @@
 namespace audioapi {
 
 template <typename TEvent>
+concept AutomationEventConcept = requires(TEvent event) {
+  { event.getAutomationTime() } -> std::convertible_to<double>;
+};
+template <AutomationEventConcept TEvent>
 class AutomationQueueBase {
  public:
   AutomationQueueBase() = default;
@@ -53,7 +57,7 @@ class AutomationQueueBase {
  protected:
   struct EventComparator {
     bool operator()(const TEvent &a, const TEvent &b) const {
-      return a.getAutomationEventTime() < b.getAutomationEventTime();
+      return a.getAutomationTime() < b.getAutomationTime();
     }
   };