feat: naive approach to streaming in beloved cpp #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmakowski2003
changed the title
michalsek
reviewed
May 22, 2025
...act-native-audio-api/common/cpp/audioapi/HostObjects/AudioBufferStreamSourceNodeHostObject.h
Outdated
Show resolved
Hide resolved
michalsek
reviewed
May 22, 2025
apps/fabric-example/ios/FabricExample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
michalsek
approved these changes
May 22, 2025
Member
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
Small nits, besides that looks good! :)
maciejmakowski2003
added a commit
that referenced
this pull request
Jun 2, 2025
* docs: add docs for oscillator node * docs: added wave shapes img * docs: removed empty periodic wave screen * docs: stereo panner node * update installation docs to include metro config (#447) * fix: linted file * Feat/onended/added state to payload (#453) * feat: added state to payload of onended event * ci: yarn format * fix: added appropriate type to arg of onended method --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * fix: number of channelCount * fix: added possibility of disconnection between node and param in ts * docs: add mention about connecting node to param * feat: naive approach to streaming in beloved cpp (#461) * feat: naive approach streaming in beloved cpp * refactor: minor improvements * fix: minor fix * fix: bring back Audiofile example * fix: renamed new node * fix: revert project.pbxproj changes and formatting --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * docs: added search bar into the documentation * Feat/streaming/additional features (#462) * feat: added bufferId arg to enqueueBuffer and attached it to onended payload * feat: added onPositionChanged event * ci: yarn format * fix: minor fix --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * Refactor/system settings and audio engine (#466) * feat: added bufferId arg to enqueueBuffer and attached it to onended payload * feat: added onPositionChanged event * ci: yarn format * fix: minor fix * fix: fixed system settings * fix: fixed engine connections * feat: implemented setAudioSessionActivity * ci: yarn format * fix: small fix --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * fix: changed type of reason to string union * fix: removed double unknown type * fix: fixed NativeAudioAPIModuleSpec on oldArch (#470) Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * fix: fixed building without withAudioAPI plugin (#471) Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * Docs/audio manager (#458) * docs: add audio manager documentation * feat: rewrote types section * docs: better info on returning types * docs: added missing explanation and aligned with new impl * fix: small typos * fix: typos * feat: extended examples * fix: minor fixes (#474) Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * fix: possibility of connecting node to param on web * chore: readme update to 0.6.0 * chore: readme update to 0.6.0 v2 * chore: add 0.6.0 link * fix: typo * Revert "Chore/update readme 0.6.0" * chore: small refactor in readme * fix: config plugin defaults and types * fix: config plugin defaults and types * fix: cleanup types * fix: fixed system playback speed (#479) Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * Refactor/system audio settings and engines (#480) * refactor: android system functions improvement * ci: yarn format * feat: added option to init audioContext suspended * refactor: refactored audio player behaviors * ci: yarn format * refactor: small refactor of AudioContextOptions * fix: small nitpick * refactor: pausing engine only if all players are paused * ci: yarn format * fix: removed synchronized decorator from AudioAPIModule --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * fix returning status in requestRecordingPermissions (#473) * fix: ios fix * fix: android fix * fix: 2nd iteration of andoroid implementation * docs: added info note about plugin (#472) * docs: added info note plugin * fix: naming * docs: removed info about connecting to only node from web audio api coverage * fix: small fix --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> Co-authored-by: michal <dydmichal@gmail.com> --------- Co-authored-by: michal <dydmichal@gmail.com> Co-authored-by: gabimoncha <gabimoncha@gmail.com> Co-authored-by: Michał Dydek <54865962+mdydek@users.noreply.github.com> Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> Co-authored-by: Michał Sęk <michal.sek@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363
Closes RNAA-12
Closes RNAA-38
Introduced changes
AudioBufferStreamSourceNodethat is responsible for playing queue ofAudioBuffersChecklist