Skip to content

feat: convolver impl #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: convolver impl #533

wants to merge 5 commits into from

Conversation

mdydek
Copy link
Contributor

@mdydek mdydek commented Jun 30, 2025 •
edited
Loading

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • added new node type convolver, which allows to do linear convolution algorithm with associated buffer, which can help achieve f.e. reverb sound

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2025
View reviewed changes
mdydek
mdydek commented Jun 30, 2025
View reviewed changes
packages/react-native-audio-api/common/cpp/audioapi/dsp/Convolver.cpp Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://publications.rwth-aachen.de/record/466561/files/466561.pdf page 111

@mdydek mdydek added the feature New feature label Jul 1, 2025
@mdydek mdydek self-assigned this Sep 4, 2025
@poneciak57
Copy link
Contributor

Current state

Right now it does not work correctly filter is not being applied as it should be.

Idea

It would be nice to strip out the Convolver and make sure that it works correctly operating on numbers in separate main.cpp. When we confirm that convolution algorithm works as expected in different enviroment we can go back to using it as an effect node.

TestCase

It is nice to test on simple defered echo filter. IR being the filter and $IR[0] = 1$, $IR[22500] = 0.7$. Outcome should be subtle echo after half a second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdydek mdydek

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdydek @poneciak57