Merged
Conversation
mdydek
reviewed
Apr 8, 2026
Collaborator
mdydek
left a comment
There was a problem hiding this comment.
I would also rename some of the files and classes, maybe ParamControlQueue, ParamAudioQueue and so on
mdydek
requested changes
Apr 8, 2026
32a511d to
a2a2b4a
Compare
8b00ec3 to
decc31d
Compare
mdydek
reviewed
Apr 10, 2026
Collaborator
mdydek
left a comment
There was a problem hiding this comment.
Files are still not renamed ParamControlQueue ...
mdydek
reviewed
Apr 13, 2026
Collaborator
mdydek
left a comment
There was a problem hiding this comment.
can you also update docs section about new errors?
c03be4e to
877f8da
Compare
mdydek
requested changes
Apr 13, 2026
mdydek
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RNAA-440
Introduced changes
AudioParamEventQueueto support between-element insertion (to comply with AP spec)AutomationQueueBase) withBoundedPriorityQueue(std::multisetbased) andAutomationRenderQueueandAutomationControlQueuesubclasses bothAutomationTimesortedresolveEventValuesto connect eventstart/endtime/valuebetween elementsAutomationControlQueueto JSI for handlingcurveExclusionerrorAutomationMethod)AutomationEventinto base (AutomationEvent) class andRenderAutomationEventclassAutomationControlQueue)RenderAutomationEventFactoryIBiquadFilterNodeto use RNAA typesChecklist