chore: Remove deprecated prop adapters #8057
Conversation
| nativeProps?: string[] | ||
| ): AnimatedPropsAdapterFunction; | ||
|
|
||
| export function createAnimatedPropAdapter( |
There was a problem hiding this comment.
Do we really want to completely remove createAnimatedPropAdapter function now? How about keeping it as a no-op with an error message?
There was a problem hiding this comment.
I think that this function wasn't used that often and removing it completely shouldn't be that painful for people who would have to migrate to the new API (usually just remove their outdated adapters code, which is no longer needed).
However, if you prefer to leave the createAnimatedPropAdapter function, then I can restore it as a no-op with the warning message.
There was a problem hiding this comment.
This was just a suggestion, we don't have to do that but if it's easy to improve the developer experience then why not
| adapters?: | ||
| | AnimatedPropsAdapterFunction | ||
| | AnimatedPropsAdapterFunction[] | ||
| | null, |
There was a problem hiding this comment.
Same as for createAnimatedPropAdapter, what about backwards compatibility?
There was a problem hiding this comment.
What do you suggest here? Should I still accept this adapters array but don't use it anywhere at all? It seems to me a bit confusing that a function takes a parameter that is completely ignored.
There was a problem hiding this comment.
We can make adapters parameter @deprecated and no-op but throw a warning with an actionable developer-friendly error message when it's used.
2 participants
Summary
This PR removes prop adapters from
useAnimatedStyleanduseAnimatedProps. It also removes the no longer neededcreateAnimatedPropAdapter