Skip to content

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Oct 15, 2025

Summary

Up to this PR classic createAnimatedComponent could only be "imported" and used by:

import Animated from 'react-native-reanimated'

const Test = Animated.createAnimatedComponent(Text)

And when user decided to import createAnimatedComponent directly it resulted in importing createAnimatedComponent from CSS. It created issues and confusion.

We've decided to also export classic createAnimatedComponent as a standalone function, so it can be used directly as createAnimatedComponent(Text) and also as Animated.createAnimatedComponent(Text)

This also lead to renaming createAnimatedComponent from CSS to createCSSAnimatedComponent, for better clearance.

Test plan

@patrycjakalinska patrycjakalinska changed the title poc: it needs to be different? chore: Export correct createAnimatedComponent Oct 16, 2025
@patrycjakalinska patrycjakalinska marked this pull request as ready for review October 16, 2025 10:25
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me looks good, but please wait for @MatiPl01 approve too 🙏

Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small suggestion

@patrycjakalinska patrycjakalinska added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 878e27a Oct 16, 2025
12 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/diffrentiate_between_createAnimatedComponent branch October 16, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants